Welcome to OGeek Q&A Community for programmer and developer-Open, Learning and Share
Welcome To Ask or Share your Answers For Others

Categories

0 votes
421 views
in Technique[技术] by (71.8m points)

hook - Prevent commit before peer review in svn

Is there any svn hook for peer review? I would like to make sure that any developer could not commit code until it gets reviewed by a peer. How can this be enforced by svn?

See Question&Answers more detail:os

与恶龙缠斗过久,自身亦成为恶龙;凝视深渊过久,深渊将回以凝视…
Welcome To Ask or Share your Answers For Others

1 Reply

0 votes
by (71.8m points)

I sense a misunderstanding here: If you are trying to add code review as a pre-check-in step, you are treating your source repository as the authority for perfect, ideal code, but keep imperfect code out of it. This is detrimental to the overall usefulness of a source repository. Code should be in the repository as early as practically possible. Code in the repository is change-tracked, easily accessible, easier to review and easier to backup.

So, go the easy route: Store code in branches (maybe an extra unreviewed folder alongside branches and tags) and review the branch before it gets merged into its target branch. The technical side gets easier, and you have no need for pre-commit hooks.


与恶龙缠斗过久,自身亦成为恶龙;凝视深渊过久,深渊将回以凝视…
OGeek|极客中国-欢迎来到极客的世界,一个免费开放的程序员编程交流平台!开放,进步,分享!让技术改变生活,让极客改变未来! Welcome to OGeek Q&A Community for programmer and developer-Open, Learning and Share
Click Here to Ask a Question

...