java - Choose a random object

Question

This question already has answers here: question from:https://stackoverflow.com/questions/65923091/choose-a-random-object

Answer 1

You might want to change the return type of getRandomElement to either return an index or the Product. It's void right now. The other thing would be wary of your class variable names. You use products as a argument for the method.

public int getRandomElement(List<Product> p){ 
  return (int)(Math.random() * (p.size()-1));
}

public Product getRandomElement(List<Product> p){ 
  return p.get((int)(Math.random() * (p.size()-1)));
} 

The first should return a random index the second an object. You might be having an indexing issue if you're scaling off the total list size.