python - Is there any way to condense my code so it does not take up so many lines?

Question

I'm writing my program in python and have it working properly, but it's over 500 lines of code. I think there is a way I can condense my code, but I'm not sure how I should do it

Here's an example of some of my code:

def click():
    if clicked1.get() == "app1":
        os.startfile(r"C:Users
edDesktopapp1")
        i = 0
        while i < 20:
            try:
                app.connect(title_re=".*app1")
                break
            except pywinauto.findwindows.ElementNotFoundError:
                time.sleep(1)
                i += 1
        app1 = app.top_window()
        app1.move_window(x1, y1)
        time.sleep(.5)
        app1.maximize()
    if clicked1.get() == "app2":
        os.startfile(r"C:Program Files (x86)app2")
        i = 0
        while i < 20:
            try:
                app.connect(title_re=".*app2")
                break
            except pywinauto.findwindows.ElementNotFoundError:
                time.sleep(1)
                i += 1
        app1 = app.top_window()
        app1.move_window(x1, y1)
        time.sleep(.5)
        app1.maximize()

I basically have about 20 of those if statements for each different application and for each different clicked (1-4). Is there any way I can shrink my code so it doesn't take up so many lines? Perhaps using variables?

question from:https://stackoverflow.com/questions/65922209/is-there-any-way-to-condense-my-code-so-it-does-not-take-up-so-many-lines

Answer 1

Here's a data driven approach that lets you add apps to the map at the top of the code, and also makes it easy for you to add additional per-app quantities to each of the map entries:

apps = {
    "app1": {
        "startfile": r"C:Users
edDesktopapp1",
        "title_re": ".*app1"
    },
    "app2": {
        "startfile": r"C:Program Files (x86)app2",
        "title_re": ".*app2"
    }
}

def click():
    if clicked1.get() in apps:
        app = apps[clicked1.get()]
        os.startfile(app["startfile"])
        i = 0
        while i < 20:
            try:
                app.connect(title_re=app["title_re"])
                break
            except pywinauto.findwindows.ElementNotFoundError:
                time.sleep(1)
                i += 1
        app1 = app.top_window()
        app1.move_window(x1, y1)
        time.sleep(.5)
        app1.maximize()