Github node action http errors always fails job

Question

I have a github action that looks something like this:

const http = require('http');
const core = require('@actions/core');


const options = {
    hostname: 'mydomain.com',
    port: 80,
    path: '/webhook',
    method: 'POST',
    headers: {
        'Content-Type': 'application/x-www-form-urlencoded',
    }
};

const postData = {
    foo: 'bar'
}

try {
    
    const strPostData = querystring.stringify(postData);
    options.headers['Content-Length'] = Buffer.byteLength(strPostData);

    const req = http.request(options)
    req.write(strPostData)
    req.end()

} catch (error) {
    core.info(error.message);
}

if mydomain.com/webhook is offline, my job fails on this action, logging:

events.js:187
      throw er; // Unhandled 'error' event
      ^

Error: connect ECONNREFUSED xxx.xxx.xxx.xxx:80
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1129:14)
Emitted 'error' event on ClientRequest instance at:
    at Socket.socketErrorListener (_http_client.js:406:9)
    at Socket.emit (events.js:210:5)
    at emitErrorNT (internal/streams/destroy.js:92:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:60:3)
    at processTicksAndRejections (internal/process/task_queues.js:80:21) ***
  errno: 'ECONNREFUSED',
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: 'xxx.xxx.xxx.xxx',
  port: 80
***

Why does it fail, why doesn't the try catch catch this?

I don't want the entire job to fail if this action fails, so how do I trap this failure and hide it from the GitHub runner?

question from:https://stackoverflow.com/questions/65914172/github-node-action-http-errors-always-fails-job

Answer 1

You will need to listen to the 'error' event to catch this

const strPostData = querystring.stringify(postData);
options.headers['Content-Length'] = Buffer.byteLength(strPostData);

const req = http.request(options)

req.on('error', (err) => {/*Error Caught*/})

req.write(strPostData)
req.end()