algorithm - I have made a program in C++ to separate words from a line by spacebar and display those words as an array. What's wrong in my code?

Question

Please help me to find a bug in this program.It separates a line into words by spacebar. And display as a list. If the first char of a word is in lower case, it is converted to uppercase.

#include <iostream>
#include <string>
using namespace std;

int main()
{
    char line[30]="Hi there buddy",List[10][20];
    unsigned int i=0,List_pos=0,no;
    int first=0,last;

    while(i!=sizeof(line)+1)
    {
        if(line[i]==' ' or i==sizeof(line))
        {
            last=i;
            no=0;
            for(int j=first;j<last;++j)
            {
                if(no==0)
                    List[List_pos][no]=toupper(line[j]);
                else
                    List[List_pos][no]=line[j];
                ++no;
            }
            ++List_pos;
            first=last+1;
        }
    ++i;
    }

    for(unsigned int a=0;a<List_pos;++a)
        cout<<"
List["<<a+1<<"]="<<List[a];

    return 0;
}

Expected Output:

List[1]=Hi    
List[2]=There    
List[3]=Buddy    

Actual Output:

List[1]=Hi    
List[2]=ThereiX?m    
List[3]=Buddy   

Answer 1

I suggest you use a string, as you already included it. And 'List is not really necessary in this situation. Try making a single for loop where you separate your line into words, in my opinion when you work with arrays you should use for loops. In your for loop, as you go through the line, you could just add a if statement which determines whether you're at the end of a word or not. I think the problem in your code is the multiple loops but I am not sure of it.

I provide you a code which works. Just adapt it to your display requirements and you will be fine

#include <iostream>
#include <string>
using namespace std;

int main()
{
    string line = "Hi there buddy";

    for (int i = 0; i < line.size(); i++) {
        if (line[i] == ' ') {
            line[i + 1] = toupper(line[i+1]);
            cout<<'
';
        } else {
            cout<<line[i];
        }

    }

    return 0;
} ```