python - How to get a list of tuples from several text files?

Question

I want to access .txt files in 46 subdirectories and extract the number of 0s and 1s in the text of each file. So far I've written this code:

from pathlib import Path

def count_0s(paths):
  for p in paths:
    list_zeros = []
    list_ones = []
    for line in p.read_text().splitlines():
      zeros = 0
      zeros += line.count('0')
      ones = 0
      ones += line.count('1')
    list_zeros.append(zeros)
    list_ones.append(ones)    
  return list_zeros, list_ones

path = "/content/drive/MyDrive/data/classes/"
paths = Path(path).glob("*/marked*.txt")
n_zeros=count_0s(paths)
n_zeros

I want to get the function return in the form of 2 lists (one with the number of 0s and the other with the number of 1s) to use in a Pandas dataframe. Sorry if the questions are duplicated.

Answer 1

There are couple mistakes in your function:

• you've added some unnecessary square brackets (splitlines() already returns a list)
• you don't iterate over characters, but over lines

Here is a corrected function:

def count_0s(paths):
  zeros_list = []
  ones_list = []
  for p in paths:
    zeros = 0
    ones = 0

    for line in p.read_text().splitlines():
        for c in line:
            if c == '0':
                zeros += 1
            else:
                ones += 1
    zeros_list.append(zeros)
    ones_list.append(ones)
  return zeros_list, ones_list

Be aware that this is probably a very inefficient way of counting 0 and 1. For example just using line.count('0') instead of a for loop can increase the speed by a factor of 10.