Welcome to OGeek Q&A Community for programmer and developer-Open, Learning and Share
Welcome To Ask or Share your Answers For Others

Categories

0 votes
609 views
in Technique[技术] by (71.8m points)

encryption - Got stuck with Caesar.c

I am trying to run the program assignment caesar.c from the edx Introduction to programming. It requires a program able to encrypt a string with the Caesar encryption: therefore, the user has to enter a key (command-line); for example with a key of 2 a 'A' character needs to be encrypted in a 'C' character; the problem starts when you have to enter a key greater than 26, which is the number of alphabetical letters. For a key of 27 and an 'A' character for example, the program must return 'B' like a key of 1.

I have tried to transform the ASCII values of the characters to alphabetical values from 0 to 26 in order to use the modulus operator when the key is equal or greater than 26. It returns me a segmentation fault. Can anyone help me with some suggestions of the causes of my error?

Here's the program:

#include <stdio.h>
#include <cs50.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>

int key;

// function for an alphabetic value with non capital letters

int alpha_low( char c )
{
    int alpha_value;
    alpha_value = (int) c - 97;
    return alpha_value + ( key % 26 );
}

// function to return to ascii valuee for non capital letters

char ascii_low( char c )
{
    return (char) alpha_low( c ) + 97;
}

// function for an alphabetic value with capital letters

int alpha_up( char c )
{
    int alpha_value;
    alpha_value = (int) c - 65;
    return alpha_value + ( key % 26 );
}

// function to return to ascii value for capital letters

char ascii_up( char c )
{
    return (char) alpha_up( c ) + 65;
}


int main(int argc, string argv[])
{
        int result;
        string p;
        key = atoi( argv[1] );

    if( argc != 2 || key < 0 )
    {
       printf("Usage: ./caesar key(positive integer)
");
       return 1;
    }

    printf("Please, write a plaintext: ");
    p = GetString();

    for( int i = 0, n = strlen(p); i < n; i++)
    {
       if ( isalpha(p[i]) )
       {
          if ( islower(p[i]) )
          {
             result = alpha_low( p[i] );
             printf("%c", ascii_low( p[i] ));
          }
          else if( islower( p[i]) )
          {
              result = alpha_up( p[i] );
              printf("%c", ascii_up( p[i]) );
          }
        }  
    }      

    return 0;
} 
See Question&Answers more detail:os

与恶龙缠斗过久,自身亦成为恶龙;凝视深渊过久,深渊将回以凝视…
Welcome To Ask or Share your Answers For Others

1 Reply

0 votes
by (71.8m points)

A function to caesar an alphabetic char should be like (decomposed in elementary steps):

int caesar_lower(int c,int key) {
    int v = c-'a'; // translate 'a'--'z' to 0--25
    v = v+key;     // translate 0--25 to key--key+25
    v = v%26;      // translate key--key+25 to key--25,0--key-1
    v = v+'a';     // translate back 0--25 to 'a'--'z'
    return v;
}

与恶龙缠斗过久,自身亦成为恶龙;凝视深渊过久,深渊将回以凝视…
OGeek|极客中国-欢迎来到极客的世界,一个免费开放的程序员编程交流平台!开放,进步,分享!让技术改变生活,让极客改变未来! Welcome to OGeek Q&A Community for programmer and developer-Open, Learning and Share
Click Here to Ask a Question

...