android - Use viewLifecycleOwner as the LifecycleOwner

Question

I have a fragment:

class MyFragment : BaseFragment() {

   // my StudentsViewModel instance
   lateinit var viewModel: StudentsViewModel

   override fun onCreateView(...){
        ...
   }

   override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
       super.onViewCreated(view, savedInstanceState)

       viewModel = ViewModelProviders.of(this).get(StudentsViewModel::class.java)
       updateStudentList()
   }

   fun updateStudentList() {
        // Compiler error on 'this': Use viewLifecycleOwner as the LifecycleOwner
        viewModel.students.observe(this, Observer {
            //TODO: populate recycler view
        })
    }
}

In my fragment, I have a instance of StudentsViewModel which is initiated in onViewCreated(...).

In, StudentsViewModel, students is a LiveData:

class StudentsViewModel : ViewModel() {
    val students = liveData(Dispatchers.IO) {
          ...
    }
}

Back to MyFragment, in function updateStudentList() I get compiler error complaining the this parameter I passed in to .observe(this, Observer{...}) that Use viewLifecycleOwner as the LifecycleOwner

Why I get this error? How to get rid of it?

Answer 1

Why I get this error?

Lint is recommending that you use the lifecycle of the fragment's views (viewLifecycleOwner) rather than the lifecycle of the fragment itself (this). Ian Lake and Jeremy Woods of Google go over the difference as part of this Android Developer Summit presentation, and Ibrahim Yilmaz covers the differences in this Medium post In a nutshell:

• viewLifecycleOwner is tied to when the fragment has (and loses) its UI (onCreateView(), onDestroyView())

• this is tied to the fragment's overall lifecycle (onCreate(), onDestroy()), which may be substantially longer

How to get rid of it?

Replace:

viewModel.students.observe(this, Observer {
        //TODO: populate recycler view
    })

with:

viewModel.students.observe(viewLifecycleOwner, Observer {
        //TODO: populate recycler view
    })

In your current code, if onDestroyView() is called, but onDestroy() is not, you will continue observing the LiveData, perhaps crashing when you try populating a non-existent RecyclerView. By using viewLifecycleOwner, you avoid that risk.